Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge all expression tests to save disk consumption #3301

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Nov 11, 2021

You can use --gtest_filter to run your special tests

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Nov 11, 2021
Aiee
Aiee previously approved these changes Nov 11, 2021
jievince
jievince previously approved these changes Nov 11, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3301 (8765572) into master (58f0b44) will increase coverage by 0.02%.
The diff coverage is 87.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
+ Coverage   85.24%   85.26%   +0.02%     
==========================================
  Files        1295     1305      +10     
  Lines      118190   120284    +2094     
==========================================
+ Hits       100748   102560    +1812     
- Misses      17442    17724     +282     
Impacted Files Coverage Δ
src/clients/storage/GraphStorageClient.cpp 73.11% <0.00%> (-3.24%) ⬇️
src/clients/storage/GraphStorageClient.h 100.00% <ø> (ø)
src/clients/storage/StorageClientBase-inl.h 73.26% <0.00%> (-4.90%) ⬇️
src/clients/storage/StorageClientBase.h 65.57% <ø> (+4.03%) ⬆️
...common/expression/test/AggregateExpressionTest.cpp 77.93% <ø> (-0.51%) ⬇️
...ommon/expression/test/ArithmeticExpressionTest.cpp 100.00% <ø> (ø)
...common/expression/test/AttributeExpressionTest.cpp 100.00% <ø> (ø)
src/common/expression/test/CaseExpressionTest.cpp 100.00% <ø> (ø)
...rc/common/expression/test/ColumnExpressionTest.cpp 100.00% <ø> (ø)
.../common/expression/test/ConstantExpressionTest.cpp 100.00% <ø> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0028f...8765572. Read the comment docs.

@yixinglu yixinglu merged commit 026dea5 into master Nov 15, 2021
@yixinglu yixinglu deleted the cleanup-expr-test branch November 15, 2021 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants