Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traverse. #3308

Merged
merged 42 commits into from
Nov 17, 2021
Merged

Traverse. #3308

merged 42 commits into from
Nov 17, 2021

Conversation

CPWstatic
Copy link
Contributor

@CPWstatic CPWstatic commented Nov 11, 2021

What type of PR is this?

  • enhancement

What does this PR do?

Added an executor called Traverse

Which issue(s)/PR(s) this PR relates to?

Part work of implementing the openCypher.

Checklist:

  • Performance impacted: We hope there are some improvement.

Release notes:

N/A `

@CPWstatic CPWstatic added do not review PR: not ready for the code review yet wip Solution: work in progress labels Nov 11, 2021
@CPWstatic CPWstatic added ready-for-testing PR: ready for the CI test and removed do not review PR: not ready for the code review yet wip Solution: work in progress labels Nov 15, 2021
@CPWstatic CPWstatic force-pushed the traverse branch 3 times, most recently from e8b971f to 01c2328 Compare November 15, 2021 06:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #3308 (8227922) into master (7f711bb) will increase coverage by 0.01%.
The diff coverage is 79.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3308      +/-   ##
==========================================
+ Coverage   85.20%   85.22%   +0.01%     
==========================================
  Files        1304     1289      -15     
  Lines      119897   119970      +73     
==========================================
+ Hits       102164   102243      +79     
+ Misses      17733    17727       -6     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.cpp 76.28% <ø> (+1.02%) ⬆️
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/common/datatypes/Edge.h 100.00% <ø> (ø)
src/common/expression/PathBuildExpression.h 100.00% <ø> (ø)
...c/common/expression/test/ExpressionContextMock.cpp 100.00% <ø> (ø)
src/graph/context/Iterator.h 73.79% <ø> (-0.69%) ⬇️
src/graph/executor/admin/SubmitJobExecutor.h 100.00% <ø> (ø)
src/graph/planner/match/MatchClausePlanner.h 100.00% <ø> (ø)
src/graph/planner/match/MatchSolver.cpp 47.05% <0.00%> (-50.00%) ⬇️
src/graph/planner/match/VertexIdSeek.h 100.00% <ø> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92c65e...8227922. Read the comment docs.

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, Only want to know what's difference between GetVertices and AppendVertices ?

@CPWstatic
Copy link
Contributor Author

Generally LGTM, Only want to know what's difference between GetVertices and AppendVertices ?

AppendVertices append vertices to a path.

@yixinglu
Copy link
Contributor

Please solve the conflicts!

Copy link
Contributor

@Shylock-Hg Shylock-Hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPWstatic CPWstatic merged commit 5eda4b8 into vesoft-inc:master Nov 17, 2021
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
* Add traverse.

* Implement buildResult.

* Refactor expand.

* Fix multi steps.

* Add AppendVertices and fix range nullptr.

* Fix override paths.

* Impl AppendVertices and fix multi paths.

* Using none_direct_dst and fix getting edge props.

* Fix duplicate edges when multiple traverse.

* Fix dedup and kind.

* Fix dup edges.

* Fix path release and reserve space by cnt.

* Enhance stats.

* Fix start from middle.

* Fix scan nodes.

* Support filter in traverse.

* Fix node filter.

* Fix yield path and edges.

* Fix CollapseProjectRule test and fix empty result of traverse.

* Fix traverse filter vertex.

* Fix zero steps and some tests.

* Fix path build.

* Fix 1..1 and vertex props.

* Fix 0 step path.

* Fix start from some non-dedup vids.

* Fix start from edge.

* Fix match index select test.

* Fix rel expr test.

* Fix remove proj test.

* Fix some test.

* Remove unused code.

* StepClause -> MatchStepRange.

* Implement the explain and clone.

* Rebase and fix compile and fix limit push down test.

* Fix path build expr test.

* Fix validator test.

* Fix parser test.

* Fix license.

* Fix typo.

* Rebase and fix.

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>

Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants