-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traverse. #3308
Traverse. #3308
Conversation
e8b971f
to
01c2328
Compare
Codecov Report
@@ Coverage Diff @@
## master #3308 +/- ##
==========================================
+ Coverage 85.20% 85.22% +0.01%
==========================================
Files 1304 1289 -15
Lines 119897 119970 +73
==========================================
+ Hits 102164 102243 +79
+ Misses 17733 17727 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, Only want to know what's difference between GetVertices
and AppendVertices
?
|
Please solve the conflicts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add traverse. * Implement buildResult. * Refactor expand. * Fix multi steps. * Add AppendVertices and fix range nullptr. * Fix override paths. * Impl AppendVertices and fix multi paths. * Using none_direct_dst and fix getting edge props. * Fix duplicate edges when multiple traverse. * Fix dedup and kind. * Fix dup edges. * Fix path release and reserve space by cnt. * Enhance stats. * Fix start from middle. * Fix scan nodes. * Support filter in traverse. * Fix node filter. * Fix yield path and edges. * Fix CollapseProjectRule test and fix empty result of traverse. * Fix traverse filter vertex. * Fix zero steps and some tests. * Fix path build. * Fix 1..1 and vertex props. * Fix 0 step path. * Fix start from some non-dedup vids. * Fix start from edge. * Fix match index select test. * Fix rel expr test. * Fix remove proj test. * Fix some test. * Remove unused code. * StepClause -> MatchStepRange. * Implement the explain and clone. * Rebase and fix compile and fix limit push down test. * Fix path build expr test. * Fix validator test. * Fix parser test. * Fix license. * Fix typo. * Rebase and fix. Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
What type of PR is this?
What does this PR do?
Added an executor called
Traverse
Which issue(s)/PR(s) this PR relates to?
Part work of implementing the openCypher.
Checklist:
Release notes:
N/A `