-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some changes to avoid confusion #3339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3339 +/- ##
==========================================
- Coverage 85.27% 85.22% -0.05%
==========================================
Files 1276 1276
Lines 118999 119004 +5
==========================================
- Hits 101475 101425 -50
- Misses 17524 17579 +55
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The original naming in the storage plan tree execution is confusing: when adding dependents to a node, all its children are set to
hasDependents_
. I believeisRoot
is more accurate.