Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to avoid confusion #3339

Merged
merged 13 commits into from
Dec 15, 2021
Merged

Conversation

wenhaocs
Copy link
Contributor

The original naming in the storage plan tree execution is confusing: when adding dependents to a node, all its children are set to hasDependents_. I believe isRoot is more accurate.

@wenhaocs wenhaocs requested review from yixinglu, panda-sheep and critical27 and removed request for yixinglu November 22, 2021 19:20
@wenhaocs wenhaocs added the ready-for-testing PR: ready for the CI test label Nov 22, 2021
@wenhaocs wenhaocs self-assigned this Nov 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2021

Codecov Report

Merging #3339 (3f1ef54) into master (fe68b0e) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3339      +/-   ##
==========================================
- Coverage   85.27%   85.22%   -0.05%     
==========================================
  Files        1276     1276              
  Lines      118999   119004       +5     
==========================================
- Hits       101475   101425      -50     
- Misses      17524    17579      +55     
Impacted Files Coverage Δ
src/common/expression/ContainerExpression.cpp 90.00% <66.66%> (-2.13%) ⬇️
src/common/utils/MetaKeyUtils.cpp 81.31% <100.00%> (ø)
src/graph/validator/test/YieldValidatorTest.cpp 91.78% <100.00%> (ø)
src/parser/test/ParserTest.cpp 100.00% <100.00%> (ø)
src/storage/exec/RelNode.h 79.06% <100.00%> (ø)
src/storage/exec/StoragePlan.h 100.00% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/graph/context/Result.cpp 85.00% <0.00%> (-9.45%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8872973...3f1ef54. Read the comment docs.

panda-sheep
panda-sheep previously approved these changes Nov 30, 2021
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SuperYoko SuperYoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27 critical27 merged commit 60c5019 into vesoft-inc:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants