Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - schema support chinese #3380

Merged
merged 12 commits into from
Dec 7, 2021
Merged

Conversation

heroicNeZha
Copy link
Contributor

@heroicNeZha heroicNeZha commented Nov 30, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

$ CREATE TAG `队伍`(`名字` string);
$ DESCRIBE TAG `队伍`
Then the result should be, in any order:
| Field | Type | Null | Default | Comment |
| "名字" | "string" | "YES" | EMPTY | EMPTY |

Which issue(s)/PR(s) this PR relates to?

#2120 tag and tag schema support Chinese or UTF-8

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@heroicNeZha heroicNeZha added doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test labels Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #3380 (4660799) into master (ab73b4c) will increase coverage by 0.04%.
The diff coverage is 98.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
+ Coverage   85.23%   85.27%   +0.04%     
==========================================
  Files        1277     1278       +1     
  Lines      119088   119149      +61     
==========================================
+ Hits       101502   101603     +101     
+ Misses      17586    17546      -40     
Impacted Files Coverage Δ
src/graph/optimizer/rule/CollapseProjectRule.cpp 98.24% <ø> (ø)
...timizer/rule/OptimizeEdgeIndexScanByFilterRule.cpp 90.54% <ø> (ø)
...ptimizer/rule/OptimizeTagIndexScanByFilterRule.cpp 90.27% <ø> (ø)
...h/optimizer/rule/PushLimitDownGetNeighborsRule.cpp 93.54% <ø> (ø)
...timizer/rule/PushStepLimitDownGetNeighborsRule.cpp 93.75% <ø> (ø)
...imizer/rule/PushStepSampleDownGetNeighborsRule.cpp 93.93% <ø> (ø)
src/graph/planner/plan/Query.h 97.61% <ø> (+0.16%) ⬆️
src/graph/util/FTIndexUtils.cpp 4.12% <ø> (ø)
src/graph/validator/FindPathValidator.cpp 84.78% <ø> (ø)
src/graph/validator/MutateValidator.cpp 94.06% <ø> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5194726...4660799. Read the comment docs.

@heroicNeZha heroicNeZha linked an issue Dec 1, 2021 that may be closed by this pull request
@Shylock-Hg
Copy link
Contributor

Better to support other languages by the way.

@heroicNeZha
Copy link
Contributor Author

heroicNeZha commented Dec 2, 2021

Better to support other languages by the way.

This change supports most multi-byte UTF-8 languages, such as :
create tag `ボリ`(`组员` string)
Execution succeeded (time spent 1396/15443 us)

@CPWstatic CPWstatic merged commit d42203d into vesoft-inc:master Dec 7, 2021
@foesa-yang foesa-yang added this to Done in Nebula Docs Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
Development

Successfully merging this pull request may close these issues.

Schema and tag or tag property name support Chinese
6 participants