Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Check the result of listHosts() #3382

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Nov 30, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Check the result of listHosts(). Currently, the result of listHosts() is never checked.

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

@Aiee Aiee added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Nov 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3382 (641d0f2) into master (fe68b0e) will decrease coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3382      +/-   ##
==========================================
- Coverage   85.27%   85.27%   -0.01%     
==========================================
  Files        1276     1276              
  Lines      118999   118997       -2     
==========================================
- Hits       101475   101472       -3     
- Misses      17524    17525       +1     
Impacted Files Coverage Δ
src/common/expression/ContainerExpression.cpp 90.00% <66.66%> (-2.13%) ⬇️
src/clients/meta/MetaClient.cpp 75.62% <100.00%> (-0.42%) ⬇️
src/graph/validator/test/YieldValidatorTest.cpp 91.78% <100.00%> (ø)
src/parser/test/ParserTest.cpp 100.00% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
src/meta/processors/BaseProcessor.h 75.67% <0.00%> (-16.22%) ⬇️
src/common/thrift/ThriftClientManager-inl.h 82.97% <0.00%> (-6.39%) ⬇️
src/common/datatypes/HostAddrOps-inl.h 75.67% <0.00%> (-2.71%) ⬇️
src/common/base/Status.h 88.63% <0.00%> (-2.28%) ⬇️
src/common/expression/LogicalExpression.cpp 91.66% <0.00%> (-1.73%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c73e1...641d0f2. Read the comment docs.

@yixinglu yixinglu merged commit d29a5a4 into vesoft-inc:master Nov 30, 2021
@Aiee Aiee deleted the minor-fix branch November 30, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants