Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix for EvaluableExprVisitor #3389

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Dec 1, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Fix EvaluableExprVisitor::visitBinaryExpr.

Additional context:

That is same as FindAnyNonEvaluableLeafExpr.
Can the implementation of EvaluableExprVisitor be unified to FindVisitor?

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

No need to change.

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Dec 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3389 (fe914a8) into master (fe68b0e) will decrease coverage by 0.02%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3389      +/-   ##
==========================================
- Coverage   85.27%   85.25%   -0.03%     
==========================================
  Files        1276     1277       +1     
  Lines      118999   119093      +94     
==========================================
+ Hits       101475   101527      +52     
- Misses      17524    17566      +42     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/kvstore/NebulaStore.h 95.23% <ø> (ø)
src/kvstore/PartManager.h 97.14% <ø> (ø)
src/graph/session/GraphSessionManager.cpp 80.79% <33.33%> (-0.82%) ⬇️
src/common/expression/ContainerExpression.cpp 90.00% <66.66%> (-2.13%) ⬇️
src/common/utils/MetaKeyUtils.cpp 81.02% <74.19%> (-0.30%) ⬇️
src/kvstore/PartManager.cpp 55.26% <80.00%> (+1.13%) ⬆️
src/graph/executor/admin/ConfigExecutor.cpp 93.84% <90.90%> (-0.70%) ⬇️
src/clients/meta/MetaClient.cpp 75.71% <100.00%> (-0.33%) ⬇️
src/graph/service/GraphFlags.cpp 100.00% <100.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab73b4c...fe914a8. Read the comment docs.

@czpmango czpmango requested a review from a team December 2, 2021 02:01
@Shylock-Hg
Copy link
Contributor

Please add test case.

@czpmango
Copy link
Contributor Author

czpmango commented Dec 3, 2021

Please add test case.

ACK.

@yixinglu yixinglu merged commit 69bd48f into vesoft-inc:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants