Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable agg function in unwind clause #3397

Merged
merged 7 commits into from
Dec 10, 2021

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 2, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

refer to https://discuss.nebula-graph.com.cn/t/topic/6742/8

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@nevermore3 nevermore3 added type/bug Type: something is unexpected ready-for-testing PR: ready for the CI test labels Dec 2, 2021
@nevermore3 nevermore3 added this to the v3.0.0 milestone Dec 2, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test the scenario which use aggregation function in WITH ?

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #3397 (7cb24f9) into master (6ccf173) will increase coverage by 0.05%.
The diff coverage is 84.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3397      +/-   ##
==========================================
+ Coverage   85.25%   85.30%   +0.05%     
==========================================
  Files        1278     1289      +11     
  Lines      119277   119820     +543     
==========================================
+ Hits       101688   102213     +525     
- Misses      17589    17607      +18     
Impacted Files Coverage Δ
src/clients/storage/StorageClient.h 100.00% <ø> (ø)
src/common/graph/Response.h 45.66% <ø> (ø)
src/common/meta/SchemaManager.h 50.00% <ø> (ø)
src/graph/context/ast/CypherAstContext.h 100.00% <ø> (ø)
src/graph/planner/plan/PlanNode.h 81.25% <ø> (ø)
src/graph/visitor/ExtractFilterExprVisitor.cpp 50.46% <36.36%> (-18.29%) ⬇️
src/clients/storage/StorageClient.cpp 78.60% <50.00%> (+6.62%) ⬆️
src/graph/validator/GoValidator.cpp 96.25% <72.72%> (-0.94%) ⬇️
.../optimizer/rule/PushFilterDownScanVerticesRule.cpp 73.91% <73.91%> (ø)
src/kvstore/raftex/RaftPart.cpp 72.46% <83.33%> (-0.09%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67bb6ff...7cb24f9. Read the comment docs.

@nevermore3
Copy link
Contributor Author

Could you test the scenario which use aggregation function in WITH ?

ok

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu merged commit 9a0fbb6 into vesoft-inc:master Dec 10, 2021
@nevermore3 nevermore3 deleted the fix_unwind_crash branch December 10, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants