Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkTypeBeforeDropIndex #3413

Merged
merged 3 commits into from
Dec 7, 2021
Merged

checkTypeBeforeDropIndex #3413

merged 3 commits into from
Dec 7, 2021

Conversation

sworduo
Copy link
Contributor

@sworduo sworduo commented Dec 6, 2021

What type of PR is this?

  • [☑️] bug
  • feature
  • enhancement

What does this PR do?

fix #3375 (reference)

Which issue(s)/PR(s) this PR relates to?

#3375 (reference)

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist：

  • Documentation affected （Please add the label if documentation needs to be modified.)
  • Incompatible （If it is incompatible, please describe it and add corresponding label.）
  • Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes：

Please confirm whether to reflect in release notes and how to describe:

                                                            `

critical27
critical27 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for contribution, LGTM.

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Dec 6, 2021
@critical27 critical27 requested review from a team December 6, 2021 09:33
@critical27 critical27 merged commit 6300233 into vesoft-inc:master Dec 7, 2021
@sworduo sworduo deleted the checkTypeBeforeDropIndex branch December 7, 2021 11:54
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Index delete problem
4 participants
@sworduo @critical27 @Shylock-Hg @Sophie-Xie