fix crash when the expression exceed the depth #3429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
+ Coverage 85.23% 85.28% +0.05%
==========================================
Files 1277 1278 +1
Lines 119088 119303 +215
==========================================
+ Hits 101502 101747 +245
+ Misses 17586 17556 -30
Continue to review full report at Codecov.
|
|
And maybe not all expression will be checked by |
The And I didn't check non-recursive expressions in |
|
According to the Single Duty Principle, I think you should write a new visitor instead of do it in |
heroicNeZha
force-pushed
the
limit_depth_of_expression
branch
2 times, most recently
from
06bf960
to
f429029
Compare
|
Generally LGTM |
heroicNeZha
force-pushed
the
limit_depth_of_expression
branch
from
f429029
to
a1494eb
Compare
heroicNeZha
force-pushed
the
limit_depth_of_expression
branch
from
a1494eb
to
090a758
Compare
…bula into limit_depth_of_expression
| checkDepth(); | ||
| SCOPE_EXIT { recoverDepth(); }; | ||
| if (!ok()) return; | ||
| for (auto &arg : expr->args()->args()) { |
| void CheckDepthVisitor::visit(SubscriptExpression *expr) { | ||
| checkDepth(); | ||
| SCOPE_EXIT { recoverDepth(); }; | ||
| if (!ok()) return; |
There was a problem hiding this comment.
consider refactor to two function that return bool and use: fa() && fb();
There was a problem hiding this comment.
this pr is closed
What type of PR is this?
What does this PR do?
fix crash When the expression's depth exceeds the maximum limit
（The depth is related to the stack size. This pr limited 815 is calculated based on the stack size of the development machine）
Which issue(s)/PR(s) this PR relates to?
fixed #3393
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: