simplify storage SIGINT signal handler #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3437 +/- ##
==========================================
+ Coverage 85.23% 85.30% +0.06%
==========================================
Files 1277 1278 +1
Lines 119088 119287 +199
==========================================
+ Hits 101502 101754 +252
+ Misses 17586 17533 -53
Continue to review full report at Codecov.
|
kikimo
reviewed
Dec 9, 2021
7 tasks
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
#### What type of PR is this? - [x] bug - [ ] feature - [ ] enhancement #### What does this PR do? closes vesoft-inc#3441 simplify graphd signal handler：Set stop condition instead of waiting all workers stop #### Which issue(s)/PR(s) this PR relates to? In vesoft-inc#3437 , it simplify storage SIGINT signal handler #### Special notes for your reviewer, ex. impact of this fix, etc: #### Additional context/ Design document: #### Checklist: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.） - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory #### Release notes: Please confirm whether to be reflected in release notes and how to describe: > ` Migrated from vesoft-inc#3542 Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
In short:
let's say we(storage server) have a thread running some task.
user send kill SIGINT signal, linux schedule the signal handler at the thread we talked about.
now, we interrupt the previous task, executing the signal handler,
it calls storage server->stop()
trying to clear everything storage server has(also include this thread!!!!).
Then we stuck.
Which issue(s)/PR(s) this PR relates to?
Storage hang at exit #3434