Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support properties in where clause #3443

Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 9, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

1、support properties function in GO sentence 's where clause

2、use DeducePropVisitor to extract the attribbute of VertexExpression & EdgeExpression

Which issue(s)/PR(s) this PR relates to?

#3117, will reconsider later

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

@nevermore3 nevermore3 added do not review PR: not ready for the code review yet doc affected PR: improvements or additions to documentation wip Solution: work in progress labels Dec 9, 2021
@nevermore3 nevermore3 added this to the v3.0.0 milestone Dec 9, 2021
@nevermore3 nevermore3 force-pushed the support_properties_in_where_clause branch from cf57ea2 to fa0180a Compare December 9, 2021 13:03
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need not to add some TCK tests?

src/graph/visitor/DeducePropsVisitor.cpp Outdated Show resolved Hide resolved
tests/tck/features/go/GO.feature Outdated Show resolved Hide resolved
@nevermore3 nevermore3 force-pushed the support_properties_in_where_clause branch 3 times, most recently from 536fb35 to b55fe0f Compare December 16, 2021 07:33
@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test and removed do not review PR: not ready for the code review yet wip Solution: work in progress labels Dec 16, 2021
@nevermore3 nevermore3 force-pushed the support_properties_in_where_clause branch from b55fe0f to 2186f33 Compare December 16, 2021 07:35
@nevermore3 nevermore3 force-pushed the support_properties_in_where_clause branch from 2186f33 to 4ac7d4f Compare December 20, 2021 12:21
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #3443 (bbeef56) into master (53b85dc) will decrease coverage by 0.00%.
The diff coverage is 86.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3443      +/-   ##
==========================================
- Coverage   85.19%   85.19%   -0.01%     
==========================================
  Files        1306     1307       +1     
  Lines      122158   122521     +363     
==========================================
+ Hits       104078   104378     +300     
- Misses      18080    18143      +63     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 95.65% <ø> (ø)
src/common/expression/VariableExpression.cpp 84.84% <ø> (-0.45%) ⬇️
src/common/geo/GeoIndex.h 100.00% <ø> (ø)
src/graph/executor/maintain/EdgeIndexExecutor.cpp 92.06% <ø> (ø)
src/graph/executor/maintain/TagIndexExecutor.cpp 92.80% <ø> (ø)
...rc/graph/executor/query/AppendVerticesExecutor.cpp 98.30% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e7f45...bbeef56. Read the comment docs.

Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This properties(*).age will be updated into properties(*).'player.age'. LGTM

@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Dec 21, 2021

Add a test case like fetch prop on * yield vertex as v and fetch prop on <edge_type> yield edge as e. And lookup , find path and match maybe should test too.

@Shylock-Hg Shylock-Hg mentioned this pull request Dec 21, 2021
7 tasks
@nevermore3
Copy link
Contributor Author

Add a test case like fetch prop on * yield vertex as v and fetch prop on <edge_type> yield edge as e. And lookup , find path and match maybe should test too.

these testcase already exist, this PR is support the properties function in where clause

@yixinglu yixinglu merged commit 5d4d0b7 into vesoft-inc:master Dec 23, 2021
@nevermore3 nevermore3 deleted the support_properties_in_where_clause branch December 27, 2021 07:28
@cooper-lzy cooper-lzy self-requested a review January 5, 2022 02:52
@foesa-yang foesa-yang added this to Done in Nebula Docs Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants