Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix add hosts #3501

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix add hosts #3501

merged 2 commits into from
Dec 20, 2021

Conversation

HarrisChu
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

if the storage does not register to the cluster, it would return E_MACHINE_NOT_FOUND, and would always send heartbeat to the follower.
a little ugly

  1. if run add host with the storage, it will be ok after updateLeader.
  2. if not, it would always update leader, and send heartbeat to meta randomly.

@HarrisChu HarrisChu added the ready-for-testing PR: ready for the CI test label Dec 20, 2021
@HarrisChu
Copy link
Contributor Author

fix #3475

@yixinglu yixinglu merged commit 73ade34 into vesoft-inc:master Dec 20, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 25, 2021
Closed
@HarrisChu HarrisChu deleted the fix_add_host branch December 28, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@critical27 critical27 critical27 approved these changes

@czpmango czpmango czpmango approved these changes

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HarrisChu @yixinglu @critical27 @czpmango