Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the bidirection edges. #3507

Merged
merged 7 commits into from
Dec 27, 2021

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 20, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Close #3505

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Dec 20, 2021
RETURN type(e) AS Type, e.start_year AS StartYear, e.end_year AS EndYear
LIMIT 3
"""
Then a ExecutionError should be raised at runtime: Scan vertices must specify limit number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confused to throw the scan vertices error, It's obviously scan edge in the query.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plan start from ScanVertices, and transformed to ScanEdges in optimizer, but in this case transform failed, so result in ScanVertices failed.

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #3507 (724ae93) into master (53b85dc) will increase coverage by 0.00%.
The diff coverage is 76.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3507   +/-   ##
=======================================
  Coverage   85.19%   85.20%           
=======================================
  Files        1306     1307    +1     
  Lines      122158   122247   +89     
=======================================
+ Hits       104078   104162   +84     
- Misses      18080    18085    +5     
Impacted Files Coverage Δ
src/common/expression/VariableExpression.cpp 84.84% <ø> (-0.45%) ⬇️
...rc/graph/executor/query/AppendVerticesExecutor.cpp 98.30% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <ø> (ø)
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <ø> (ø)
src/graph/optimizer/rule/IndexScanRule.h 100.00% <ø> (ø)
...mizer/rule/PushLimitDownEdgeIndexRangeScanRule.cpp 20.00% <0.00%> (-0.69%) ⬇️
...raph/optimizer/rule/PushLimitDownIndexScanRule.cpp 14.81% <0.00%> (-0.57%) ⬇️
...imizer/rule/PushLimitDownTagIndexRangeScanRule.cpp 20.00% <0.00%> (-0.69%) ⬇️
src/graph/planner/plan/Query.h 97.22% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea4889...724ae93. Read the comment docs.

@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Dec 23, 2021
RETURN type(e) AS Type, e.start_year AS StartYear, e.end_year AS EndYear
LIMIT 3
"""
Then a ExecutionError should be raised at runtime: Scan vertices must specify limit number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error msg really confuses me. What's the correct way to write this sentence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MATCH ()-[e:is_teacher]->()
      RETURN type(e) AS Type, e.start_year AS StartYear, e.end_year AS EndYear
      LIMIT 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't allow the bidirection.

@yixinglu yixinglu merged commit fd8d8a8 into vesoft-inc:master Dec 27, 2021
@Shylock-Hg Shylock-Hg deleted the fix/get-bidirect-edges branch February 9, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match get vertices error
6 participants