logrotate #3541
Merged
logrotate #3541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install lld when pull request , will set lld as default linker.
yixinglu
reviewed
Dec 27, 2021
src/daemons/SetupLogging.cpp
Outdated
| if (!FileUtils::makeDir(FLAGS_log_dir)) { | ||
| return Status::Error("Failed to create log directory `%s'", FLAGS_log_dir.c_str()); | ||
| } | ||
| if (!FileUtils::exist(FLAGS_log_dir) and !FileUtils::makeDir(FLAGS_log_dir)) { |
src/daemons/SetupLogging.h
Outdated
| @@ -0,0 +1,16 @@ | |||
| /* Copyright (c) 2018 vesoft inc. All rights reserved. | |||
yixinglu
approved these changes
Dec 27, 2021
critical27
reviewed
Dec 27, 2021
| @@ -20,6 +20,8 @@ | |||
| --stderr_log_file=metad-stderr.log | |||
| # Copy log messages at or above this level to stderr in addition to logfiles. The numbers of severity levels INFO, WARNING, ERROR, and FATAL are 0, 1, 2, and 3, respectively. | |||
| --stderrthreshold=2 | |||
| # wether logging files' name contain time stamp, If Using logrotate to rotate logging files, than should set it to true. | |||
critical27
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
logrotate rotate log
Which issue(s)/PR(s) this PR relates to?
close #3066
Special notes for your reviewer, ex. impact of this fix, etc:
do not merge util thirdparty 3.0 is merged.
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: