Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

round the float/double when insert it to integer column #3572

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 27, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

Which issue(s)/PR(s) this PR relates to?

Close #3473

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Sophie-Xie Sophie-Xie added doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test labels Dec 27, 2021
yixinglu
yixinglu previously approved these changes Dec 27, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yixinglu yixinglu added the type/bug Type: something is unexpected label Dec 27, 2021
@yixinglu yixinglu merged commit e2b66dd into vesoft-inc:master Dec 27, 2021
@cooper-lzy cooper-lzy self-requested a review January 5, 2022 02:33
@foesa-yang foesa-yang added this to Done in Nebula Docs Jan 17, 2022
@randomJoe211 randomJoe211 moved this from Done to Ready for archiving in Nebula Docs Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a double value can be set to a int32/int64 property successfully
5 participants