add LogMonitor to check log disk freeBytes and change log level when space is almost full #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nivras
force-pushed
the
disk_full_issue
branch
from
596b4be
to
190bd7b
Compare
critical27
reviewed
Dec 28, 2021
|
Close #3423 |
Nivras
force-pushed
the
disk_full_issue
branch
from
0b06a59
to
48bfca5
Compare
pengweisong
reviewed
Dec 31, 2021
liuyu85cn
previously approved these changes
Jan 5, 2022
liuyu85cn
reviewed
Jan 5, 2022
critical27
approved these changes
Jan 9, 2022
pengweisong
reviewed
Jan 10, 2022
| void LogMonitor::checkAndChangeLogLevel() { | ||
| getLogDiskFreeByte(); | ||
|
|
||
| if (FLAGS_log_min_reserved_bytes_to_fatal > FLAGS_log_min_reserved_bytes_to_error || |
There was a problem hiding this comment.
I think !(FLAGS_log_min_reserved_bytes_to_fatal > FLAGS_log_min_reserved_bytes_to_warn && FLAGS_log_min_reserved_bytes_to_error > FLAGS_log_min_reserved_bytes_to_fatal) is more readable ?
pengweisong
approved these changes
Jan 10, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Jan 15, 2022
…space is almost full (#3576) * add LogMonitor to check the log disk is full * fix comments * add comments for default flags Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
CPWstatic
added a commit
that referenced
this pull request
Jan 17, 2022
* add LogMonitor to check log disk freeBytes and change log level when space is almost full (#3576) * add LogMonitor to check the log disk is full * fix comments * add comments for default flags Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> * Ldbc test cases. (#3537) * Add ldbc test/ * Add all cases. * Fix some test cases. * Fix ldbc cases. * Fix pytest. Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> * fix issue 3675 (#3678) * Fix expression rewrite (#3614) * Do not transfer the filter expression if it contains 2 lableAttribute exprs * Fix expression overflow check * Fix rewriteRelExpr * Refactor rewriteRelExpr * Fix log usage * Check whether the minus expression contains string * Add tck cases * Address comments * Fix conflicts * Address comments * modify metrics in conf files * Address comments * fix divide zone should be failed if two zones use the same host (#3699) * Support more check about merge zone arguments (#3703) * fix match index (#3694) * check scheam * add test case * fix graph crash * address comment' ' * add test case * fix error * fix vid select error * fix unit test error * address comment * fix issue 3601 (#3666) Co-authored-by: Nivras <12605142+Nivras@users.noreply.github.com> Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
add LogMonitor to check log disk freeBytes and change log level when space is almost full
in default config, if log disk free space is less than 256M, change log level to WARNING, and if space less than 64M, change log level to DEBUG, and less than 4M, change log level to FATAL.
If log disk space is bigger than those flag, and log level have changed before(maybe someone clean the log), LogMonitor will change the log level to the old value(which in config file).
Which issue(s)/PR(s) this PR relates to?
#3423
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: