Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake modification. #3596

Merged
merged 5 commits into from
Dec 29, 2021

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Dec 29, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

After third-party upgrade to 3.0, I found the SSL over self signed certificate can't work well again, I track from fbthrift to openssl and check related commits/release notes, but don't found anything. Finally found the mistake modification in #3263 by binary search debug between commits.

Why this issue don't report in CI? Because in self signed certificate mode, we only enable graph SSL, and tck don't support SSL before. But now tck already support it in #3471 , so this won't be ignored again. And we also could set option to let fbthrift throw when setup SSL failed.

Which issue(s)/PR(s) this PR relates to?

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context/ Design document:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the corresponding label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

                                                            `

@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Dec 29, 2021
@CPWstatic CPWstatic merged commit fa6d838 into vesoft-inc:master Dec 29, 2021
@Shylock-Hg Shylock-Hg deleted the fix/ssl-selfsigned-cert branch February 9, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants