-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property pruner #3750
Merged
Merged
Property pruner #3750
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
b6b1ecc
property pruner
jievince d82606f
postprocess works.
jievince c453057
add Travese::pruneProperties
jievince 4bbf081
make vertexprops of travese be null when node alias is not used
jievince 180bcbf
fix extractPropsFromExps for tagPropExpr and edgePropexpr, vFilter an…
jievince e3e7248
add PropertyTracker::update for project node
jievince 0f36c8d
add DeduceMatchPropsVisitor and FLAGS_enable_opt_collapse_project_rule
jievince 481bcbb
add Filter::pruneProperties and only 3 tck cases not passed
jievince 6173b72
Do not do propsUsed.colsSet.erase(it)
jievince 8c78e8c
revert labeltagpropexpr and pass all tck
jievince 792d0f1
add hasAlias, add deduce types for id, src, dst func
jievince 7d4f9dc
rename visitor
jievince 93ec6c5
ingore func id, src, dst, type, typeid, rank, hash in property tracke…
jievince bcae49b
add Aggregate::pruneProperties and store the alias of id/src/dst... t…
jievince 97071d6
format tck
jievince c41e056
remove some unusedless headers
jievince b761996
add tck for plan
jievince ab9f684
rename has1, has2, has3
jievince cde0eb3
add flag_enable_optimizer_property_pruner_rule and support prune edge…
jievince cfc0275
add kUnknownEdgeType
jievince 72b0c22
add PrunePropertiesVisitor
jievince f60ca32
remove PlanNode::pruneProperties, and move PropertyTracker to Propert…
jievince 4f80bc0
add PrunePropertiesRule.feature
jievince b8a96af
add markDeleted interface
jievince cb33f65
remove unused code
jievince 679ff67
fix header macro
jievince 1e936ea
update tck
jievince a04dc00
Merge branch 'master' into property-pruner
czpmango File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* Copyright (c) 2020 vesoft inc. All rights reserved. | ||
* | ||
* This source code is licensed under Apache 2.0 License. | ||
*/ | ||
|
||
#ifndef PLAN_PLANNODEVISITOR_H_ | ||
#define PLAN_PLANNODEVISITOR_H_ | ||
|
||
#include "graph/planner/plan/PlanNode.h" | ||
#include "graph/planner/plan/Query.h" | ||
|
||
namespace nebula { | ||
namespace graph { | ||
|
||
class PlanNodeVisitor { | ||
public: | ||
virtual ~PlanNodeVisitor() = default; | ||
|
||
virtual void visit(PlanNode *node) = 0; | ||
virtual void visit(Filter *node) = 0; | ||
virtual void visit(Project *node) = 0; | ||
virtual void visit(Aggregate *node) = 0; | ||
virtual void visit(Traverse *node) = 0; | ||
virtual void visit(AppendVertices *node) = 0; | ||
virtual void visit(BiJoin *node) = 0; | ||
}; | ||
|
||
} // namespace graph | ||
} // namespace nebula | ||
|
||
#endif // PLAN_PLANNODEVISITOR_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should reuse
enable_optimizer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How could
enable_optimizer
be able to control whether to enable a single rule?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we don't provide a way to control single optimization. And in my mind,
enable_optimizer
must control all optimizations include this of course.