Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 3869 #3894

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix issue 3869 #3894

merged 2 commits into from
Feb 15, 2022

Conversation

cangfengzhs
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #3869

Description:

Temporarily use Concurrenthashmap to fix thread unsafety issues. There is a certain performance penalty.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

None

@Sophie-Xie Sophie-Xie added cherry-pick-v3.0 PR: need cherry-pick to this version cherry-pick-v2.6 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test and removed cherry-pick-v2.6 PR: need cherry-pick to this version labels Feb 15, 2022
@Sophie-Xie Sophie-Xie merged commit 2561d2f into vesoft-inc:master Feb 15, 2022
Sophie-Xie added a commit that referenced this pull request Feb 15, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatsManager is not thread safe
4 participants