Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up include files #3906

Closed
wants to merge 9 commits into from
Closed

clean up include files #3906

wants to merge 9 commits into from

Conversation

jiayuehua
Copy link
Contributor

What type of PR is this?

  • [*] bug
  • feature
  • [*] enhancement

What problem(s) does this PR solve?

Issue(s) number:

#3667

Description:

How do you solve it?

use iwyu first, then by hand.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jiayuehua jiayuehua added the ready-for-testing PR: ready for the CI test label Feb 16, 2022
@dutor
Copy link
Contributor

dutor commented Feb 16, 2022

There are too many redundant include directives, although of which the content will not be parsed multiple times or in vain. This situation is possibly inroduced by the pattern below:

// file b
#include <a>
// file c.cpp
#include <a>  // already included within file b
#include <b>

This PR may help to speed up the build. But I don't think it's a good thing that include directives make up nearly 10% of LOC in our codebase. This is exactly what @sherman-the-tank concerned about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants