Binary pack script opt #4010
Closed
Binary pack script opt #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wey-gu
requested review from
sherman-the-tank,
yixinglu and
dutor
as code owners
|
will manually test when I got bandwidth to, plz don't review now. |
CPWstatic
reviewed
Mar 21, 2022
| for daemon in ${daemons[@]} | ||
| do | ||
| if [[ ! -f $install_dir/scripts/nebula.service ]] ; then | ||
| $install_dir/scripts/nebula.service stop ${daemon} |
There was a problem hiding this comment.
This operation can be dangerous in a production environment. I suggest that we do not do this implicitly.
HarrisChu
reviewed
Mar 21, 2022
| @@ -141,6 +141,8 @@ function start_daemon { | |||
| local command="${executable} --flagfile ${config}" | |||
| INFO "Starting ${daemon_name}..." | |||
| eval ${command} | |||
| local port=$(get_port_from_config ${config}) | |||
| wait_for_port_listening ${port} 20 || WARN "Timed out waiting for ${daemon_name} to finish starting, but it may still be running" | |||
There was a problem hiding this comment.
prefer to implement this logic in nebula process.
and the behavior should be same with running in container.
There was a problem hiding this comment.
or just like readinessprobe in k8s, curl a http interface?
|
this will be revisited later when I have bandwidth to think about it. |
|
closing it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close #4003
close #4009
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: