Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression is stateful to store the result of evaluation, so we can't… #4190

Merged
merged 4 commits into from
Apr 20, 2022
Merged

Expression is stateful to store the result of evaluation, so we can't… #4190

merged 4 commits into from
Apr 20, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Apr 20, 2022 •
edited by Sophie-Xie
Loading

… share it inter threads.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

fixed #4184

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected cherry-pick-v3.1 PR: need cherry-pick to this version labels Apr 20, 2022
@critical27
Copy link
Contributor

critical27 commented Apr 20, 2022 •
edited
Loading

- -b, quick fix 👍

@nevermore3
Copy link
Contributor

This bug seems to have nothing to do with the data set, why did CI not report this problem

@Shylock-Hg
Copy link
Contributor Author

This bug seems to have nothing to do with the data set, why did CI not report this problem

Dataset won't share inter threads, each job has independent dataset to write.

@critical27
Copy link
Contributor

This bug seems to have nothing to do with the data set, why did CI not report this problem

It only will happens when storage execute in multiple thread.

@Sophie-Xie Sophie-Xie merged commit 2e2987f into vesoft-inc:master Apr 20, 2022
@Shylock-Hg Shylock-Hg deleted the fix/avoid-share-expr-inter-threads branch April 20, 2022 11:52
Sophie-Xie pushed a commit that referenced this pull request Apr 20, 2022
@Shylock-Hg @Sophie-Xie
Expression is stateful to store the result of evaluation, so we can't… (
d7d0576 
#4190)

* Expression is stateful to store the result of evaluation, so we can't share it inter threads.

* Fix defef nullptr.
Sophie-Xie added a commit that referenced this pull request Apr 20, 2022
@Sophie-Xie @jievince
@czpmango @Aiee @nevermore3 @critical27 @Shylock-Hg @liwenhui-soul
Cherry pick v3.1.0 (0414-0420) (#4183)
f4a2299 
* fix issue 4152 (#4158)

* Fix optional of multi-match (#4159)

* fix optional of multi-match

* format

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix incompatibility imported by #4116 (#4165)

* Add SaveGraphVersionProcessor to separate client version check and version saving

* Update error code

* Update error code

* optimizer path (#4162)

* optimizer multi-shortest path

* new algorithm

* fix error

* skip heartbeat for tool (#4177)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix/null pattern expression input (#4180)

* Move input rows of Traverse and AppendVertices.

* Avoid skip validate pattern expression with aggregate.

* Fix case.

* Revert "Move input rows of Traverse and AppendVertices."

This reverts commit 7fd1d38.

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix wrong space key after dropping hosts (#4182)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix vertex is missing from snapshot (#4189)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Expression is stateful to store the result of evaluation, so we can't… (#4190)

* Expression is stateful to store the result of evaluation, so we can't share it inter threads.

* Fix defef nullptr.

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
@jamieliu1023 jamieliu1023 mentioned this pull request Apr 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevermore3 nevermore3 nevermore3 approved these changes

@critical27 critical27 critical27 approved these changes

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@cangfengzhs cangfengzhs Awaiting requested review from cangfengzhs

Assignees
No one assigned
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

match v limit 20000 may crash the storaged
4 participants
@Shylock-Hg @critical27 @nevermore3 @Sophie-Xie