Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize input/var property expression to get property from tuple by #4242

Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented May 9, 2022

index to avoid hash table lookup.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4174

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added this to the v3.2.0 milestone May 9, 2022
@Shylock-Hg Shylock-Hg added type/enhancement Type: make the code neat or more efficient ready-for-testing PR: ready for the CI test labels May 9, 2022
@Shylock-Hg
Copy link
Contributor Author

Shylock-Hg commented May 9, 2022

Origin benchmark:

============================================================================
/nebula/src/graph/context/test/InputVarPropBenchmark.cpprelative  time/iter  iters/s
============================================================================
inputVarPropEval(test)                                      32.79ns   30.50M
============================================================================

Current benchmark:

 ============================================================================
 /nebula/src/graph/context/test/InputVarPropBenchmark.cpprelative  time/iter  iters/s
 ============================================================================
 inputVarPropEval(test)                                      11.82ns   84.59M
 ============================================================================

Comment on lines 70 to 79
const Value& InputPropertyExpression::eval(ExpressionContext& ctx) {
return ctx.getInputProp(prop_);
if (!propIndex_.has_value()) {
auto indexResult = ctx.getInputPropIndex(prop_);
if (!indexResult.ok()) {
return Value::kEmpty;
}
propIndex_ = indexResult.value();
}
return ctx.getColumn(propIndex_.value());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember we have a ColumnIndexExpr? It looks like that rewriteing InputPropExpr to ColumnIndexExpr is more easy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, we can add an optimize rule to do it. But current optimization is also useful now and no need to rewrite expression.

@Shylock-Hg Shylock-Hg requested a review from jievince June 13, 2022 05:48
@Sophie-Xie Sophie-Xie merged commit 3718a90 into vesoft-inc:master Jun 14, 2022
@Shylock-Hg Shylock-Hg deleted the optimize/get-property-by-index branch June 14, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize retrieving Input/Variable property by index instead of property name lookup
4 participants