Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push vFilter down. #4260

Merged
merged 5 commits into from
Jun 7, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented May 16, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Sub job of #4122

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added type/enhancement Type: make the code neat or more efficient ready-for-testing PR: ready for the CI test labels May 16, 2022
@Shylock-Hg Shylock-Hg added this to the v3.2.0 milestone May 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Merging #4260 (9c15c59) into master (fba3b18) will increase coverage by 0.01%.
The diff coverage is 81.48%.

@@            Coverage Diff             @@
##           master    #4260      +/-   ##
==========================================
+ Coverage   84.92%   84.93%   +0.01%     
==========================================
  Files        1328     1329       +1     
  Lines      131930   132015      +85     
==========================================
+ Hits       112045   112133      +88     
+ Misses      19885    19882       -3     
Impacted Files Coverage Δ
...optimizer/rule/PushVFilterDownScanVerticesRule.cpp 79.45% <65.38%> (-9.62%) ⬇️
src/graph/planner/match/MatchSolver.cpp 49.47% <66.66%> (+0.01%) ⬆️
src/graph/planner/plan/Query.cpp 70.32% <75.00%> (+2.14%) ⬆️
...rc/graph/optimizer/rule/PushFilterDownNodeRule.cpp 87.09% <87.09%> (ø)
src/graph/executor/query/TraverseExecutor.cpp 95.29% <100.00%> (ø)
src/graph/planner/plan/Query.h 96.26% <100.00%> (+0.04%) ⬆️
src/graph/visitor/ExtractFilterExprVisitor.cpp 71.25% <100.00%> (+0.22%) ⬆️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-3.86%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 84.18% <0.00%> (-3.85%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba3b18...9c15c59. Read the comment docs.

CPWstatic
CPWstatic previously approved these changes May 30, 2022
Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I prefer we had more comments, especially the rule matching part.

@Sophie-Xie Sophie-Xie merged commit 591a8c5 into vesoft-inc:master Jun 7, 2022
@Shylock-Hg Shylock-Hg deleted the optimize/push-vfilter-down branch June 7, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants