fix zone lost in backup #4319
Merged
fix zone lost in backup #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda-sheep
requested review from
pengweisong,
liwenhui-soul,
critical27,
wenhaocs and
a team
critical27
reviewed
Jun 14, 2022
| if (zoneRet != nebula::cpp2::ErrorCode::E_ZONE_NOT_FOUND) { | ||
| if (zoneRet == nebula::cpp2::ErrorCode::SUCCEEDED) | ||
| LOG(ERROR) << "Zone " << zoneName << " have existed"; | ||
| code = nebula::cpp2::ErrorCode::E_KEY_HAS_EXISTS; |
There was a problem hiding this comment.
Perhaps you need to return the error code from zoneRet, otherwise, some kvstore error could be vanished. Besides, the if in line 64 miss a bracket
There was a problem hiding this comment.
Good catch, thx.
panda-sheep
force-pushed
the
fix_backup_zone_info
branch
from
5b81dee
to
4e86a46
Compare
pengweisong
previously approved these changes
Jun 14, 2022
panda-sheep
force-pushed
the
fix_backup_zone_info
branch
from
82264f9
to
c1d402f
Compare
pengweisong
approved these changes
Jun 15, 2022
critical27
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
Solve the problem of zonename inconsistency during restore.
Currently a host is a zone by default.
When restoring, because the host needs to be replaced, so the zone needs to be replaced.
And when replacing the zone, need to replace the zone used in spaceDesc.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: