Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash on dropping fulltext index #4384

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 6, 2022

Invoking std::move(StatusOr<T>).value() will STEAL the value from StatusOr into a temporary object, which will be destroyed shortly.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 6, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.2 PR: need cherry-pick to this version label Jul 6, 2022
@critical27 critical27 merged commit 2e39ce5 into vesoft-inc:master Jul 7, 2022
@dutor dutor deleted the fix-ft-index branch July 7, 2022 02:30
critical27 added a commit that referenced this pull request Jul 9, 2022
* Fixed crash on dropping fulltext index (#4384)

* [Raft] fix crash in certain cases (#4372)

* fix crash

* fix crash when follower has just received snapshot and no wal in it

* fix after receive snapshot, the local term is not right

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix lint build error (#4390)

update Check License Header

* enhance atomic log buffer memory usage (#4386)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.2 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants