Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the format of the config yaml of the nba dataset to the latest… #4404

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Jul 12, 2022

… 3.0 version for nebula-importer.

What type of PR is this?

  • [] bug
  • [] feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4403

Description:

How do you solve it?

Update format.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2022

CLA assistant check
All committers have signed the CLA.

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Jul 12, 2022
@Sophie-Xie
Copy link
Contributor

@xtcyclist plz fix the error of CI, thanks~~

@xtcyclist xtcyclist force-pushed the fix_nba_data_config_for_importer branch from f9fbc78 to 2cf91fb Compare July 12, 2022 15:42
@Aiee
Copy link
Contributor

Aiee commented Jul 13, 2022

Seems the config yaml is used to load schema at nebula/nebula/tests/common/utils.py::413

@xtcyclist xtcyclist force-pushed the fix_nba_data_config_for_importer branch from 695e377 to 3cc1f87 Compare July 13, 2022 06:15
@xtcyclist
Copy link
Contributor Author

Seems the config yaml is used to load schema at nebula/nebula/tests/common/utils.py::413

yes...

@xtcyclist
Copy link
Contributor Author

the current config file is still in use. close the pr.

@xtcyclist xtcyclist closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants