Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODE_OF_CONDUCT.md #4468

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Update CODE_OF_CONDUCT.md #4468

merged 3 commits into from
Jul 29, 2022

Conversation

tian-zhong
Copy link
Contributor

@tian-zhong tian-zhong commented Jul 27, 2022

Code of Conduct typically means how contributor should behave in this community. The current contents here are helpful coding syle guide.
It is also best to rename the filename to "CODE_STYLE_GUIDE.md"

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Code of Conduct typically means how contributor should behave in this community. The current contents here are helpful coding syle guide.
It is also best to rename the filename to "CODE_STYLE_GUIDE.md"
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2022

CLA assistant check
All committers have signed the CLA.

Sophie-Xie
Sophie-Xie previously approved these changes Jul 29, 2022
@Sophie-Xie Sophie-Xie requested a review from wey-gu July 29, 2022 01:53
Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the file name, too?

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Jul 29, 2022
@Sophie-Xie Sophie-Xie merged commit d456abd into master Jul 29, 2022
@Sophie-Xie Sophie-Xie deleted the tian-zhong-patch-1 branch July 29, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants