Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong image path for architecture #4471

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

TommyLemon
Copy link
Contributor

@TommyLemon TommyLemon commented Jul 28, 2022

the original image path "https://github.com/vesoft-inc/nebula-docs/raw/master/images/Nebula%20Arch.png" is outdated and cannot be loaded by browsers.
https://github.com/vesoft-inc/nebula/blob/master/README-CN.md
image
image

I used the image path for architecture from English README as a replacement.
image

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Replace with the image path from English README.md
image

And now it can show the image.
image

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:
Fixed image loading error for Chinese README.md

the original image path "https://github.com/vesoft-inc/nebula-docs/raw/master/images/Nebula%20Arch.png" is outdated and cannot be loaded by browsers.
I used the image path for architecture from English README as a replacement.
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2022

CLA assistant check
All committers have signed the CLA.

@Sophie-Xie
Copy link
Contributor

Thanks for contribution.
But I think we should change the image link from doc, @randomJoe211 pls check it.

@randomJoe211
Copy link
Contributor

randomJoe211 commented Jul 29, 2022

@TommyLemon Thanks! Please use this stable URL:
https://docs-cdn.nebula-graph.com.cn/figures/nebula-graph-architecture_3.png
And please sign the CLA.

@TommyLemon
Copy link
Contributor Author

TommyLemon commented Aug 2, 2022

@TommyLemon Thanks! Please use this stable URL: https://docs-cdn.nebula-graph.com.cn/figures/nebula-graph-architecture_3.png And please sign the CLA.

@randomJoe211 Hi, I've already changed the architecture image path with the url you gave me:
image

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Aug 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4471 (54f08a9) into master (b20964a) will increase coverage by 0.12%.
The diff coverage is 84.69%.

@@            Coverage Diff             @@
##           master    #4471      +/-   ##
==========================================
+ Coverage   84.56%   84.68%   +0.12%     
==========================================
  Files        1344     1346       +2     
  Lines      134121   134256     +135     
==========================================
+ Hits       113414   113701     +287     
+ Misses      20707    20555     -152     
Impacted Files Coverage Δ
src/graph/executor/StorageAccessExecutor.h 60.00% <ø> (-4.45%) ⬇️
src/graph/executor/query/AppendVerticesExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetNeighborsExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.h 100.00% <ø> (ø)
src/graph/service/PermissionCheck.cpp 79.59% <ø> (-1.66%) ⬇️
src/graph/validator/FetchEdgesValidator.h 100.00% <ø> (ø)
.../graph/validator/test/GetSubgraphValidatorTest.cpp 100.00% <ø> (ø)
src/meta/processors/job/BalanceJobExecutor.cpp 66.66% <ø> (+1.51%) ⬆️
src/meta/processors/job/BalanceJobExecutor.h 75.00% <ø> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ee515...54f08a9. Read the comment docs.

@Sophie-Xie
Copy link
Contributor

@TommyLemon Thanks! pls sign the CLA, otherwise I can't merge.

image

image

@TommyLemon
Copy link
Contributor Author

@TommyLemon Thanks! pls sign the CLA, otherwise I can't merge.

image

image

@Sophie-Xie ok, I've already signed the CLA

@Sophie-Xie Sophie-Xie merged commit 5d553be into vesoft-inc:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants