Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Community in Badges #4481

Merged
merged 6 commits into from
Aug 9, 2022
Merged

doc: Community in Badges #4481

merged 6 commits into from
Aug 9, 2022

Conversation

wey-gu
Copy link
Contributor

@wey-gu wey-gu commented Aug 3, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

  • rebranding name of Nebula Graph as NebulaGraph
  • fixed arch image for CN readme
  • Added Badges for exposing community meetings, discussions, etc.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@wey-gu wey-gu changed the title Community in Badges doc: Community in Badges Aug 3, 2022
@Sophie-Xie
Copy link
Contributor

Good job!

Do you need to add Chinese forums and Tencent conferences to English md?
image

@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Aug 3, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Aug 3, 2022

Good job!

Do you need to add Chinese forums and Tencent conferences to English md? image

Yes, that's done on purpose for the reason:

  1. most of the fresh visitors won't notice the CN readme, thus seeing it here with Chinese char could have a better chance to navigate them there :)
  2. it will be ignored by global visitors as they are Chinese chars, thus no confusing will be brought i guess

Thanks :)

Sophie-Xie
Sophie-Xie previously approved these changes Aug 3, 2022
@vesoft-inc vesoft-inc deleted a comment from wey-gu Aug 3, 2022
@whitewum
Copy link
Contributor

whitewum commented Aug 3, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

  • fixed naming of Nebula Graph as NebulaGraph
  • fixed arch image for CN readme
  • Added Badges for exposing community meetings, discussions, etc.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • [x ] N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

A space between Nebula and Graph heavily changes the VI.
This had been a meeting of discussionion and was determined in 2019 as Nebula Graph.

@wey-gu
Copy link
Contributor Author

wey-gu commented Aug 3, 2022

@Sophie-Xie @whitewum Sorry I thought that was a new thing to do rebrand :-P, reverted those changes now.

randomJoe211
randomJoe211 previously approved these changes Aug 3, 2022
Sophie-Xie
Sophie-Xie previously approved these changes Aug 3, 2022
whitewum
whitewum previously approved these changes Aug 3, 2022
@Sophie-Xie Sophie-Xie dismissed stale reviews from whitewum, randomJoe211, and themself via b3a8ba1 August 4, 2022 05:16
Sophie-Xie
Sophie-Xie previously approved these changes Aug 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #4481 (cab1150) into master (5d553be) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4481      +/-   ##
==========================================
+ Coverage   84.63%   84.70%   +0.07%     
==========================================
  Files        1346     1346              
  Lines      134263   134262       -1     
==========================================
+ Hits       113629   113732     +103     
+ Misses      20634    20530     -104     
Impacted Files Coverage Δ
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
...c/meta/processors/parts/GetPartsAllocProcessor.cpp 81.66% <0.00%> (-1.67%) ⬇️
src/codec/RowReaderWrapper.cpp 78.57% <0.00%> (-1.03%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 79.77% <0.00%> (-0.77%) ⬇️
src/kvstore/RocksEngine.cpp 81.09% <0.00%> (-0.50%) ⬇️
src/graph/executor/Executor.cpp 79.50% <0.00%> (-0.50%) ⬇️
src/storage/test/StatsTaskTest.cpp 94.61% <0.00%> (-0.45%) ⬇️
src/kvstore/raftex/RaftPart.cpp 70.14% <0.00%> (-0.45%) ⬇️
src/storage/query/GetNeighborsProcessor.cpp 88.68% <0.00%> (-0.33%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Sophie-Xie Sophie-Xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Shinji-IkariG Shinji-IkariG merged commit 9204b88 into master Aug 9, 2022
@Shinji-IkariG Shinji-IkariG deleted the wey-gu-Community-Badges branch August 9, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants