New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stats log print to console when we start process. #4550
Merged
critical27
merged 6 commits into
vesoft-inc:master
from
Milittle:fix_stats_log_print_to_console
Aug 22, 2022
Merged
Fix stats log print to console when we start process. #4550
critical27
merged 6 commits into
vesoft-inc:master
from
Milittle:fix_stats_log_print_to_console
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we before setLogging, init our stats, when we adjust high level verbose log. it will be output logs to console.
panda-sheep
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks for your contribution
jievince
approved these changes
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@
## master #4550 +/- ##
==========================================
+ Coverage 84.67% 84.70% +0.03%
==========================================
Files 1354 1355 +1
Lines 134943 135012 +69
==========================================
+ Hits 114261 114365 +104
+ Misses 20682 20647 -35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
critical27
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we before setupLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: I do not pull new issue for this.
Description:
we before setupLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.
How do you solve it?
I adjust the init stats order from main process in Metad and Storaged
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: