Add meta offline detect #4610
Merged
Add meta offline detect #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
approved these changes
Sep 6, 2022
pengweisong
approved these changes
Sep 8, 2022
critical27
approved these changes
Sep 8, 2022
panda-sheep
reviewed
Sep 9, 2022
| @@ -2079,6 +2095,10 @@ void RaftPart::sendHeartbeat() { | |||
| if (!hosts[resp.first]->isLearner() && | |||
| resp.second.get_error_code() == nebula::cpp2::ErrorCode::SUCCEEDED) { | |||
| ++numSucceeded; | |||
| // only metad 0 space 0 part need this state now. | |||
| if (spaceId_ == kDefaultSpaceId) { | |||
| hosts[resp.first]->setLastHeartbeatTime(time::WallClock::fastNowInMilliSec()); | |||
|
checked on 3.3rc and ent-3.3rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
issue from ent version https://github.com/vesoft-inc/nebula-ent/issues/1153
Description:
Metad status is not checked now and hardcoded in show meta hosts.
How do you solve it?
When leader of space0 part0 receive heartbeat response, record the last time. Check it when show command is called.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: