Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tagless #4652

Merged
merged 3 commits into from Sep 19, 2022
Merged

fix tagless #4652

merged 3 commits into from Sep 19, 2022

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Sep 16, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

getProp interface's behave is

before tagless
1、 if <vid + tag> exists in kvstore return value else 2
2、 if vid exisits in tagless vids return value else return nothing

after tagless
1、if <vid+tag> exists in kvstore return value else return nothing

When attribute clipping, if there is no specified tag at the vertex, all tags in the schema need to be added

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Sophie-Xie Sophie-Xie merged commit 480b29a into vesoft-inc:master Sep 19, 2022
@shanlai
Copy link

shanlai commented Sep 19, 2022

the following cases still fail:
test seek by edge index[nba]
test seek by edge index[nba int vid]
test seek by edge with properties[nba]
test seek by edge with properties[nba int vid]

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants