Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable types collected and graph crash #4724

Merged
merged 8 commits into from Oct 18, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Oct 14, 2022

add test cases

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4721

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Oct 14, 2022
@czpmango czpmango added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Oct 14, 2022
@czpmango czpmango added the doc affected PR: improvements or additions to documentation label Oct 14, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.3 PR: need cherry-pick to this version label Oct 17, 2022
@foesa-yang foesa-yang self-assigned this Oct 18, 2022
@HarrisChu
Copy link
Contributor

checked pass offline

@Sophie-Xie Sophie-Xie merged commit 95e0f43 into vesoft-inc:master Oct 18, 2022
Sophie-Xie added a commit that referenced this pull request Oct 20, 2022
* Fix variable types collected and graph crash

add test cases

small fix

* unskip some test cases related to multiple query parts

* small delete

* fmt

* Fix ldbc BI R5 implementation

Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sophie-Xie added a commit that referenced this pull request Oct 20, 2022
* fix dep of loop in go planner (#4736)

* fix inappropriate error code from raft (#4737)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Fix variable types collected and graph crash (#4724)

* Fix variable types collected and graph crash

add test cases

small fix

* unskip some test cases related to multiple query parts

* small delete

* fmt

* Fix ldbc BI R5 implementation

Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* stats handle the flag use_vertex_key (#4738)

* JobManager related fix (#4742)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* download job related fix (#4754)

* fixed case-when error (#4744)

* fixed case-when error

* fix tck

* fix tck

* fix tck

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Refine go planner (#4750)

* refine go planner

* update

* fix ctest

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Co-authored-by: canon <87342612+caton-hpg@users.noreply.github.com>
@czpmango czpmango removed the doc affected PR: improvements or additions to documentation label Oct 21, 2022
@foesa-yang foesa-yang removed their assignment Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants