fix storage job #4762
Merged
fix storage job #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperYoko
commented
Oct 20, 2022
| @@ -84,7 +84,7 @@ class StorageJobExecutor : public JobExecutor { | |||
| } | |||
|
|
|||
| JobDescription getJobDescription() override { | |||
| JobDescription ret; | |||
| JobDescription ret{space_, jobId_, cpp2::JobType::UNKNOWN}; | |||
There was a problem hiding this comment.
JobType is not used in storage job executor and call line. Set to unknown.
critical27
approved these changes
Oct 21, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Oct 21, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sophie-Xie
added a commit
that referenced
this pull request
Oct 21, 2022
* logging error if any error in step (#4759) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix storage job (#4762) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix issue 4765 (#4768) * Avoid full scan of match when there is an Relational In predicate (#4748) * Avoid match full scan when has in predicate fix small fix add test case small change add test cases small fix fmt * small delete Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
fill space and job id in storage job executor
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: