-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial fix optional match 4745 #4767
Closed
xtcyclist
wants to merge
15
commits into
vesoft-inc:master
from
xtcyclist:partial_fix_optional_match_4745
Closed
Partial fix optional match 4745 #4767
xtcyclist
wants to merge
15
commits into
vesoft-inc:master
from
xtcyclist:partial_fix_optional_match_4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a3f263
to
79b2c91
Compare
…t/nebula into partial_fix_optional_match_4745
…t/nebula into partial_fix_optional_match_4745
After discussion, I close this PR because it only stops a singular We need to discuss a PR to fully address all issues around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-v3.3
PR: need cherry-pick to this version
ready for review
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4745
Description:
The where clause is omitted in a singular optional match, resulting in wrong responses.
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: