Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix optional match 4745 #4767

Closed

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Oct 21, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4745

Description:

The where clause is omitted in a singular optional match, resulting in wrong responses.

How do you solve it?

  • Added a seperate if-scope to prevent singular optional matches producing random results.
  • Leave the other issues of optional matches for further discussions and fixes.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

  • Needs to check whether this would cause other problems.
  • There are other known problems with optional match, which are left out of this PR.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • [] Documentation affected (Please add the label if documentation needs to be modified.)
  • [] Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist force-pushed the partial_fix_optional_match_4745 branch from 0a3f263 to 79b2c91 Compare October 21, 2022 04:28
@xtcyclist xtcyclist added do not review PR: not ready for the code review yet ready-for-testing PR: ready for the CI test cherry-pick-v3.3 PR: need cherry-pick to this version and removed ready-for-testing PR: ready for the CI test labels Oct 21, 2022
@xtcyclist xtcyclist marked this pull request as draft October 21, 2022 07:11
@xtcyclist xtcyclist marked this pull request as ready for review October 21, 2022 07:31
@xtcyclist xtcyclist added ready for review and removed do not review PR: not ready for the code review yet labels Oct 21, 2022
@xtcyclist
Copy link
Contributor Author

xtcyclist commented Oct 21, 2022

After discussion, I close this PR because it only stops a singular optional match producing random wrong results without completely fixing all problems around optional match. So it comes with a risk of sabotaging other queries, many of which may not have been covered by our current tcks.

We need to discuss a PR to fully address all issues around optional match.

@xtcyclist xtcyclist closed this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants