Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inner variable race condition #4850

Merged

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Nov 10, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4845
Close https://github.com/vesoft-inc/nebula-ent/issues/1576
Close #4843

Description:

In previous, try to force user create list comprehension/reduce/predication expression with unique variable name, but this change lead to too much wired object dependencies, so this PR just fix two mistake generation of inner variable.
In the future, plan to refactor inner variable by remove it from the global variable map to Expression Eval Context. This will resolve these problems completely and could fix the related #4844 .

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Nov 10, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 84.56% // Head: 84.62% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (142a4aa) compared to base (63a63ac).
Patch coverage: 93.84% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4850      +/-   ##
==========================================
+ Coverage   84.56%   84.62%   +0.06%     
==========================================
  Files        1358     1358              
  Lines      136387   136396       +9     
==========================================
+ Hits       115331   115425      +94     
+ Misses      21056    20971      -85     
Impacted Files Coverage Δ
src/graph/visitor/VidExtractVisitor.cpp 48.83% <50.00%> (-0.15%) ⬇️
src/storage/test/GetPropTest.cpp 94.80% <88.46%> (-0.54%) ⬇️
src/graph/util/ExpressionUtils.cpp 94.76% <93.75%> (-0.11%) ⬇️
src/graph/util/ParserUtil.cpp 94.01% <93.75%> (-0.16%) ⬇️
src/common/plugin/fulltext/FTUtils.h 72.34% <100.00%> (+6.30%) ⬆️
src/graph/context/ExecutionContext.cpp 92.98% <100.00%> (+0.12%) ⬆️
src/graph/context/QueryContext.cpp 100.00% <100.00%> (ø)
src/graph/context/QueryContext.h 91.66% <100.00%> (ø)
src/graph/context/Symbols.cpp 91.78% <100.00%> (-0.33%) ⬇️
src/graph/context/Symbols.h 100.00% <100.00%> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yixinglu yixinglu merged commit a7e6e02 into vesoft-inc:master Nov 11, 2022
@Shylock-Hg Shylock-Hg deleted the fix/inner-variable-race-condition branch November 11, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
4 participants