Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate expressions in with clauses that do not have other inputs #4871

Closed
wants to merge 4 commits into from

Conversation

xtcyclist
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4854

Description:

Expressions in with clause that does not have inputs from its previous clauses haven't been evaluated.

How do you solve it?

Replace the for loop that checks whether there are inputs to the with clause with a do-while loop that only check this after evaluating expressions.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • TCK

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added the ready-for-testing PR: ready for the CI test label Nov 14, 2022
@xtcyclist xtcyclist changed the title Fix #4854 Evaluate expressions in with clauses that do not have other inputs Nov 14, 2022
@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Nov 15, 2022
@xtcyclist xtcyclist added ready for review cherry-pick-v3.3 PR: need cherry-pick to this version and removed cherry-pick-v3.3 PR: need cherry-pick to this version labels Nov 15, 2022
@xtcyclist
Copy link
Contributor Author

After checking with openCyper standards, this is an non-issue. Close it.

@xtcyclist xtcyclist closed this Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property needed by return * may has been prunned.
1 participant