Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #4903

Merged
merged 3 commits into from
Nov 21, 2022
Merged

fix typo #4903

merged 3 commits into from
Nov 21, 2022

Conversation

hezhizhen
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Fixed some typo.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@hezhizhen hezhizhen requested a review from a team as a code owner November 17, 2022 14:48
yixinglu
yixinglu previously approved these changes Nov 18, 2022
codesigner
codesigner previously approved these changes Nov 18, 2022
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Nov 19, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 76.78% // Head: 76.83% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (d7892f0) compared to base (6f240e3).
Patch coverage: 73.24% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4903      +/-   ##
==========================================
+ Coverage   76.78%   76.83%   +0.05%     
==========================================
  Files        1102     1102              
  Lines       80953    81063     +110     
==========================================
+ Hits        62160    62286     +126     
+ Misses      18793    18777      -16     
Impacted Files Coverage Δ
src/graph/context/Symbols.cpp 91.78% <ø> (ø)
src/graph/executor/admin/SubmitJobExecutor.cpp 56.94% <ø> (ø)
.../graph/executor/algo/MultiShortestPathExecutor.cpp 98.55% <ø> (ø)
...timizer/rule/OptimizeEdgeIndexScanByFilterRule.cpp 87.67% <ø> (-6.93%) ⬇️
src/graph/planner/Planner.h 100.00% <ø> (ø)
src/graph/planner/match/MatchPathPlanner.cpp 98.52% <ø> (ø)
src/graph/validator/ACLValidator.h 89.65% <ø> (ø)
src/graph/validator/MatchValidator.cpp 88.07% <ø> (ø)
src/meta/processors/admin/AdminClient.cpp 63.99% <ø> (ø)
src/meta/processors/job/JobManager.h 100.00% <ø> (ø)
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~~~

@hezhizhen
Copy link
Contributor Author

I don't know how to fix the failed test ...

@wey-gu
Copy link
Contributor

wey-gu commented Nov 21, 2022

I don't know how to fix the failed test ...

No worries, it shouldn't be relevant to your changes.

@Shinji-IkariG Shinji-IkariG merged commit 28f8994 into vesoft-inc:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants