make evaluation of inner var expr thread-safe #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jievince
force-pushed
the
thread-safe-inner-var
branch
from
b1628e8
to
e32606e
Compare
jievince
commented
Nov 22, 2022
Comment on lines
42
to
+46
| {listElement, ConstantExpression::make(pool_, static_cast<int64_t>(i))}); | ||
| auto *nodeValue = VariableExpression::make(pool_, node->alias()); | ||
| // The alias of node is converted to a inner variable. | ||
| // e.g. MATCH (v:player) WHERE [t in [v] | (v)-[:like]->(t)] RETURN v | ||
| // More cases could be found in PathExprRefLocalVariable.feature | ||
| auto *nodeValue = VariableExpression::makeInner(pool_, node->alias()); |
There was a problem hiding this comment.
node->alias() is converted to a inner var expr here.
jievince
requested review from
Shylock-Hg,
yixinglu,
czpmango and
nevermore3
Shylock-Hg
reviewed
Nov 22, 2022
| @@ -316,6 +324,9 @@ class StorageExpressionContext final : public ExpressionContext { | |||
|
|
|||
| // name -> Value with multiple versions | |||
| std::unordered_map<std::string, std::vector<Value>> valueMap_; | |||
|
|
|||
| // Expression value map that stores the value of innerVar | |||
| std::unordered_map<std::string, Value> exprValueMap_; | |||
There was a problem hiding this comment.
Why is it MT-safe? And I don't see you create different ExprCtx for each thread.
There was a problem hiding this comment.
See
Every thread has its own QueryExpressionContext.
nevermore3
approved these changes
Nov 22, 2022
Codecov ReportBase: 76.77% // Head: 76.84% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
==========================================
+ Coverage 76.77% 76.84% +0.06%
==========================================
Files 1102 1102
Lines 81064 81091 +27
==========================================
+ Hits 62240 62316 +76
+ Misses 18824 18775 -49
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yixinglu
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fix #4844
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: