Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor listener related interface and data structure #4927

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Nov 23, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

This is a prepare for later poc, we will add new type of listener

  1. Reorder data structure, see ListenersMap related change.
  2. Separate add/remove of space/part for storage and listener.

BTW, listener related code in community version is out of sync with enterprise version (for example, the base class Listener). Why?! Hope we don't have too much conflicts later in enterprise version. I think this PR could unify all usage in both version. @panda-sheep

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Base: 76.82% // Head: 76.83% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (d3be344) compared to base (b251e2f).
Patch coverage: 44.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4927      +/-   ##
==========================================
+ Coverage   76.82%   76.83%   +0.01%     
==========================================
  Files        1102     1101       -1     
  Lines       81101    81124      +23     
==========================================
+ Hits        62302    62335      +33     
+ Misses      18799    18789      -10     
Impacted Files Coverage Δ
src/clients/meta/MetaClient.h 92.30% <ø> (ø)
src/kvstore/Listener.h 39.13% <ø> (ø)
src/kvstore/NebulaStore.h 78.57% <ø> (ø)
src/kvstore/PartManager.h 89.47% <ø> (ø)
src/kvstore/plugins/elasticsearch/ESListener.h 0.00% <0.00%> (ø)
src/kvstore/PartManager.cpp 64.70% <18.18%> (-8.63%) ⬇️
src/clients/meta/MetaClient.cpp 76.02% <34.54%> (-0.03%) ⬇️
src/kvstore/NebulaStore.cpp 69.42% <54.41%> (-0.20%) ⬇️
src/common/meta/Common.h 69.23% <60.00%> (ø)
src/graph/visitor/PropertyTrackerVisitor.cpp 82.71% <75.00%> (+0.16%) ⬆️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

src/common/meta/Common.h Show resolved Hide resolved
src/kvstore/NebulaStore.h Outdated Show resolved Hide resolved
Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

src/clients/meta/MetaClient.cpp Outdated Show resolved Hide resolved
panda-sheep
panda-sheep previously approved these changes Nov 24, 2022
@critical27 critical27 changed the title Rector listener related interface and data structure Refactor listener related interface and data structure Nov 24, 2022
@critical27 critical27 merged commit 819b84d into vesoft-inc:master Nov 24, 2022
@critical27 critical27 deleted the listener branch November 24, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants