-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor listener related interface and data structure #4927
Conversation
Codecov ReportBase: 76.82% // Head: 76.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4927 +/- ##
==========================================
+ Coverage 76.82% 76.83% +0.01%
==========================================
Files 1102 1101 -1
Lines 81101 81124 +23
==========================================
+ Hits 62302 62335 +33
+ Misses 18799 18789 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
This is a prepare for later poc, we will add new type of listener
ListenersMap
related change.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: