push limit down index scan #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
previously approved these changes
Dec 7, 2022
yixinglu
reviewed
Dec 8, 2022
jievince
force-pushed
the
push-limit-down-indexscan
branch
from
23cf5de
to
e9726a5
Compare
yixinglu
approved these changes
Dec 8, 2022
Aiee
approved these changes
Dec 8, 2022
czpmango
reviewed
Dec 8, 2022
Comment on lines
+63
to
+75
| auto scanNode = matched.planNode({0, 0, 0}); | ||
| if (scanNode->kind() == PlanNode::Kind::kScanVertices) return false; | ||
| // If the scanNode is kIndexScan, and the filter looks like `player._tag IS NOT EMPTY`, | ||
| // the limit could also be pushed down | ||
| if (filter->kind() != Expression::Kind::kIsNotEmpty) { | ||
| return false; | ||
| } | ||
| auto *isNotEmpty = static_cast<const UnaryExpression *>(filter); | ||
| auto *operand = isNotEmpty->operand(); | ||
| if (operand->kind() != Expression::Kind::kTagProperty) { | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
We should be cautious about adding these case-by-case codes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: