Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the max depth of plan tree in optimizer #5050

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 13, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #4982.
Related https://github.com/vesoft-inc/nebula-ent/issues/1487.

Description:

In most cases, we can considier to constrict the depth of the plan tree to avoid stack overflow crash caused by some bad queries.
But for some queries such as statement1 interest statement2 interest statement3 ...,
which is a very normal statement, even if there are many statements to intersect,
we may need to consider the multi-way operator in planner to avoid the overflow.
e.g.

The binary intersect operator:

    intersect
    /       \
intersect   c 
  /     \
a       b

The multi-way intersect operator:

    intersect
    /   |    \
   a    b     c

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 13, 2022
Copy link
Contributor

@xtcyclist xtcyclist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to check the depth. Maybe we could factor in the depth of the tree as well as other factors altogether to prune the traversal of the optimization space in 5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict the max depth of plan tree in optimizer to avoid stack overflow
3 participants