Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors in the executor when an unwind operator is applied on a… #5052

Closed

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Dec 13, 2022

… non-list data type.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #5051

Description:

Multiple bugs have been reported while executing unwind on a non-list data type, which is not the original target for unwind. Unwind is designed to flat lists, not other types. And, these bugs run deep into the codes. Better delay their fixes, report errors in such cases and fix them later, if needed.

How do you solve it?

Report errors if an unwind is applied on non-list types. This effectively disables unwind for non-list types.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

I've checked that this PR does not affect the doc. In the doc, all queries are executing unwind on lists. https://docs.nebula-graph.com.cn/3.3.0/3.ngql-guide/8.clauses-and-options/unwind/

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist marked this pull request as draft December 13, 2022 16:16
@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Dec 13, 2022
@xtcyclist
Copy link
Contributor Author

Found an easy fix. Close this PR.

@xtcyclist xtcyclist closed this Dec 14, 2022
@xtcyclist xtcyclist deleted the disable_unwind_non_list branch December 14, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect result after unwind
1 participant