Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for intersect/union, limit, group by, order by, variable, list exprs #5061

Merged
merged 6 commits into from
Dec 28, 2022
Merged

Add tests for intersect/union, limit, group by, order by, variable, list exprs #5061

merged 6 commits into from
Dec 28, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 15, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

By the way, fix #5112, fix #5114

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince changed the title add some tests for expr Add tests for intersect/union, limit, group by, order by, variable, list exprs Dec 26, 2022
@jievince jievince marked this pull request as ready for review December 26, 2022 09:14
@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 26, 2022
@jievince jievince force-pushed the expr-tck branch 2 times, most recently from 54a009c to 5c5aa21 Compare December 26, 2022 11:35
@Sophie-Xie Sophie-Xie added the priority/hi-pri Priority: high label Dec 27, 2022
nevermore3
nevermore3 previously approved these changes Dec 27, 2022
View reviewed changes
codesigner
codesigner reviewed Dec 27, 2022
View reviewed changes
Copy link
Contributor

@codesigner codesigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

tests/tck/features/match/PipeAndVariable.feature Show resolved Hide resolved
@Sophie-Xie Sophie-Xie merged commit 97f5186 into vesoft-inc:master Dec 28, 2022
@jievince jievince deleted the expr-tck branch December 28, 2022 07:19
@wey-gu wey-gu mentioned this pull request Dec 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shylock-Hg Shylock-Hg Shylock-Hg left review comments

@codesigner codesigner codesigner approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

Assignees
No one assigned
Labels
priority/hi-pri Priority: high ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
5 participants
@jievince @codesigner @nevermore3 @Shylock-Hg @Sophie-Xie