Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index test cases #5083

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Add index test cases about:

  1. Index that contains FIXED_STRING property
  2. TTL in index value
  3. Basic compound index test in tck

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review labels Dec 21, 2022
@critical27 critical27 added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Dec 21, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 77.34% // Head: 77.44% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (3288546) compared to base (fd46ba9).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5083      +/-   ##
==========================================
+ Coverage   77.34%   77.44%   +0.09%     
==========================================
  Files        1105     1105              
  Lines       82127    82149      +22     
==========================================
+ Hits        63518    63617      +99     
+ Misses      18609    18532      -77     
Impacted Files Coverage Δ
src/storage/exec/IndexScanNode.cpp 96.72% <ø> (+0.54%) ⬆️
src/common/expression/AttributeExpression.cpp 94.59% <83.33%> (-3.74%) ⬇️
src/graph/validator/MatchValidator.cpp 89.52% <100.00%> (+0.01%) ⬆️
src/storage/BaseProcessor.h 91.66% <100.00%> (+0.23%) ⬆️
...rc/meta/processors/config/ListConfigsProcessor.cpp 75.00% <0.00%> (-20.84%) ⬇️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/meta/processors/BaseProcessor.h 76.92% <0.00%> (-15.39%) ⬇️
src/graph/executor/query/TraverseExecutor.h 90.00% <0.00%> (-6.43%) ⬇️
src/graph/executor/StorageAccessExecutor.h 54.54% <0.00%> (-4.55%) ⬇️
src/common/thread/GenericWorker.h 80.76% <0.00%> (-3.85%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 6a525a0 into vesoft-inc:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants