Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add job permission check for data balance #5099

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

SuperYoko
Copy link
Contributor

@SuperYoko SuperYoko commented Dec 23, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Users except GUEST can do data balance.

How do you solve it?

Add data balance permission check for writespace.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

liwenhui-soul
liwenhui-soul previously approved these changes Dec 23, 2022
@Sophie-Xie Sophie-Xie added the priority/hi-pri Priority: high label Dec 26, 2022
@SuperYoko SuperYoko added the ready-for-testing PR: ready for the CI test label Dec 26, 2022
@Sophie-Xie Sophie-Xie merged commit 44e4906 into vesoft-inc:master Dec 26, 2022
@SuperYoko SuperYoko deleted the add_job_permission branch March 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/hi-pri Priority: high ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants