-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the crash caused by a nullptr variable #5100
Conversation
Codecov ReportBase: 76.96% // Head: 77.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
+ Coverage 76.96% 77.82% +0.85%
==========================================
Files 1108 1108
Lines 82405 82420 +15
==========================================
+ Hits 63425 64141 +716
+ Misses 18980 18279 -701
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close https://github.com/vesoft-inc/nebula-ent/issues/1971
Close #5101
Description:
ex->what() is called without checking whether ex is nullptr.
How do you solve it?
For this else body in particular, no need to call ex->what().
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: