Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crash caused by a nullptr variable #5100

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

xtcyclist
Copy link
Contributor

@xtcyclist xtcyclist commented Dec 23, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close https://github.com/vesoft-inc/nebula-ent/issues/1971
Close #5101

Description:

ex->what() is called without checking whether ex is nullptr.

How do you solve it?

For this else body in particular, no need to call ex->what().

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@xtcyclist xtcyclist added ready-for-testing PR: ready for the CI test ready for review labels Dec 23, 2022
jievince
jievince previously approved these changes Dec 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Base: 76.96% // Head: 77.82% // Increases project coverage by +0.85% 🎉

Coverage data is based on head (2ef9442) compared to base (8e7aa68).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5100      +/-   ##
==========================================
+ Coverage   76.96%   77.82%   +0.85%     
==========================================
  Files        1108     1108              
  Lines       82405    82420      +15     
==========================================
+ Hits        63425    64141     +716     
+ Misses      18980    18279     -701     
Impacted Files Coverage Δ
src/clients/storage/StorageClientBase-inl.h 69.33% <0.00%> (-7.38%) ⬇️
src/graph/session/GraphSessionManager.h 87.50% <0.00%> (-12.50%) ⬇️
src/storage/BaseProcessor-inl.h 75.26% <0.00%> (-7.53%) ⬇️
src/graph/executor/StorageAccessExecutor.h 52.27% <0.00%> (-6.82%) ⬇️
src/graph/executor/query/TraverseExecutor.h 90.00% <0.00%> (-6.43%) ⬇️
src/clients/storage/StorageClientBase.h 56.45% <0.00%> (-3.23%) ⬇️
src/storage/mutate/AddEdgesProcessor.cpp 78.62% <0.00%> (-3.06%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
src/graph/executor/query/ProjectExecutor.cpp 61.11% <0.00%> (-1.75%) ⬇️
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

codesigner
codesigner previously approved these changes Dec 23, 2022
jievince
jievince previously approved these changes Dec 23, 2022
yixinglu
yixinglu previously approved these changes Dec 25, 2022
Copy link
Contributor

@kikimo kikimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophie-Xie Sophie-Xie merged commit a8fee05 into vesoft-inc:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/hi-pri Priority: high ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphd crashed inserting edges
8 participants