fix issue1527(pruning properties) #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Dec 26, 2022
| | id | name | dependencies | operator info | | ||
| | 7 | Aggregate | 6 | | | ||
| | 6 | Project | 5 | | | ||
| | 5 | AppendVertices | 4 | { "props": "[{\"props\":[\"_tag\"],\"tagId\": 3}, {\"props\":[\"_tag\"],\"tagId\": 4}, {\"props\":[\"_tag\"],\"tagId\": 5}]" } | |
There was a problem hiding this comment.
better to remove the tagId field in plan since it depends on runtime context.
| @@ -1,6 +1,7 @@ | |||
| # Copyright (c) 2021 vesoft inc. All rights reserved. | |||
| # | |||
| # This source code is licensed under Apache 2.0 License. | |||
| @jmq | |||
jievince
reviewed
Dec 26, 2022
nevermore3
force-pushed
the
fix_issue1668
branch
from
21615fe
to
e0b11d2
Compare
xtcyclist
force-pushed
the
fix_issue1668
branch
from
e0b11d2
to
c14f816
Compare
xtcyclist
previously approved these changes
Dec 26, 2022
xtcyclist
force-pushed
the
fix_issue1668
branch
from
c14f816
to
b2b032b
Compare
nevermore3
force-pushed
the
fix_issue1668
branch
from
b2b032b
to
11dae72
Compare
jievince
approved these changes
Dec 26, 2022
xtcyclist
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
close #4954
close https://github.com/vesoft-inc/nebula-ent/issues/1959
close https://github.com/vesoft-inc/nebula-ent/issues/1527
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: