Add more fulltext index tck case #5122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. fix ESListener crash when there is no elasticsearch
SuperYoko
approved these changes
Dec 27, 2022
critical27
reviewed
Dec 27, 2022
| @@ -70,7 +54,13 @@ bool ESListener::apply(const BatchHolder& batch) { | |||
| pickTagAndEdgeData(std::get<0>(log), std::get<1>(log), std::get<2>(log), callback); | |||
| } | |||
| if (!bulk.empty()) { | |||
| auto status = esAdapter_.bulk(bulk); | |||
| auto esAdapterRes = getESAdapter(); | |||
There was a problem hiding this comment.
Why we need to retrieve adapter for each data?
There was a problem hiding this comment.
Because the password of elasticsearch may be modified during the system operation. Therefore, you need to obtain the configuration of the elasticsearch service again.
In addition, there was a problem before that. If there was no sign in text service when adding listener, the nebula-listener would crash directly. Therefore, the address of elasticsearch cannot be obtained during initialization.
critical27
approved these changes
Dec 27, 2022
| @@ -70,7 +54,13 @@ bool ESListener::apply(const BatchHolder& batch) { | |||
| pickTagAndEdgeData(std::get<0>(log), std::get<1>(log), std::get<2>(log), callback); | |||
| } | |||
| if (!bulk.empty()) { | |||
| auto status = esAdapter_.bulk(bulk); | |||
| auto esAdapterRes = getESAdapter(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: